Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utils for amd cpu #5894

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

AYUSHJAIN951
Copy link
Contributor

get_family utility update for amd x86_64 arch to return with family details Add util for x86_64 arch to get model number
Add Util to get amd zen info

Signed-off-by: Ayush Jain ayush.jain3@amd.com

Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AYUSHJAIN951, thank you for this. The code overall LGTM. I just have few comments which you might consider. Let me know what you think about it, thank you.

avocado/utils/cpu.py Outdated Show resolved Hide resolved
avocado/utils/cpu.py Show resolved Hide resolved
avocado/utils/cpu.py Outdated Show resolved Hide resolved
get_family utility update for amd x86_64 arch to return with family details
Add util for x86_64 arch to get model number
Add Util to get amd zen info

Signed-off-by: Ayush Jain <ayush.jain3@amd.com>
Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@richtja richtja merged commit af38b8e into avocado-framework:master Apr 3, 2024
60 checks passed
@AYUSHJAIN951 AYUSHJAIN951 deleted the amd_cpu_changes branch April 3, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 105
Development

Successfully merging this pull request may close these issues.

None yet

2 participants