Merge two loops #5923
Closed
Merge two loops #5923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changxuqing
changed the title
|
Hi @richtja ,Could you please help me check the pr? |
richtja
requested changes
May 28, 2024
There was a problem hiding this comment.
Hi @changxuqing, sorry for the late reply. Thank you for your changes it LGTM. I have just comments to the commits format.
Also, I saw that we lack the test coverage for this method. Since you are touching this. Would you be so kind and write a unit test for it in unit/utils/astring.py. Thank you.
avocado/utils/astring.py
Outdated
| @@ -147,7 +140,7 @@ def strip_console_codes(output, custom_codes=None): | |||
| if special_code == tmp_word: | |||
| continue | |||
| old_word = tmp_word | |||
| return_str += tmp_word[len(special_code) :] | |||
| return_str += tmp_word[len(special_code):] | |||
There was a problem hiding this comment.
IIUIC this shouldn't be part of this commit, am I right?
avocado/utils/astring.py
Outdated
| @@ -140,7 +140,7 @@ def strip_console_codes(output, custom_codes=None): | |||
| if special_code == tmp_word: | |||
| continue | |||
| old_word = tmp_word | |||
| return_str += tmp_word[len(special_code):] | |||
| return_str += tmp_word[len(special_code) :] | |||
There was a problem hiding this comment.
The commit message, doesn't correspond to the changes. Can you please update the commit message?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operations of converting characters to ASCII values and generating a list of bits can be combined into one loop, reducing the number of passes.