Test Loader: support for enable/disable docstring tags [v2] #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sphinx will attempt to fetch the Python objects inventory during the build process. If for some reason, this test is being run on a machine that can not access that address simply because of network restrictions (or the developer may simply be on a plane) then it's better to SKIP the test than to give a false positive. Changes from v0: * Use unittest2 on Python 2.6 Signed-off-by: Cleber Rosa <crosa@redhat.com>
Inside test classes there may docstrings which may contain tags that give special meaning. The tags are defined by ":avocado: <value>" in a single line. For now the only two "official" Avocado tags values exist: * enable: the class is an Avocado INSTRUMENTED test, even if it doesn't "look like" one. * disable: the class is *NOT* an Avocado INSTRUMENTED test, even if looks like one. Changes from v0: * Use unittest2 on Python 2.6 Signed-off-by: Cleber Rosa <crosa@redhat.com>
Since the test loader now attempts to find Avocado instrumented tests
by using a parser and doesn't really load/execute test files, it can't
tell if a given class inherits from avocado.Test.
For those cases, a developer may signal, using a docstring tag, that
either:
* A test class that doesn't look like an Avocado test class is indeed
one (":avocado: enable")
* A test class that looks like an Avocado test class should not be
treated as such (":avocado: disable")
Also included is a a simple optimization by breaking earlier from the
parser loop.
Changes from v1:
* Added two more tests and suggestions by Lukáš Doktor
Changes from v0:
* Added fix reported by Lukáš Doktor
Signed-off-by: Cleber Rosa <crosa@redhat.com>
CC: Lukáš Doktor <ldoktor@redhat.com>
lmr
added a commit
that referenced
this pull request
Oct 7, 2015
Test Loader: support for enable/disable docstring tags [v2]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the test loader now attempts to find Avocado instrumented tests by using a parser and doesn't really load/execute test files, it can't tell if a given class inherits from avocado.Test.
For those cases, a developer may signal, using a docstring tag, that either:
Also included is a a simple optimization by breaking earlier from the parser loop.
Please test these, and for v1 I'll update the diagrams and documentations.
The documentation is on PR #828.
Changes from v1:
Changes from v0: