Safe Loader: a second, more abstract and reusable implementation [v0] #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is to hold utilities that are used to implement the safe, AKA ast-based, test loader. Signed-off-by: Cleber Rosa <crosa@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>
This little utility function is going to be used in the safe loader module, so it's a good idea to just put it into our collection of utility modules. Signed-off-by: Cleber Rosa <crosa@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>
Using the safe loader features, this scripts looks for unittests in the given Python source code values, retuning them one per line. The main goal is to allow Avocado to run unittests (including its own) by means of the external runner. A sample session / command line would look like this: $ cd avocado/selftests/unit $ avocado run `../../contrib/avocado-find-unittests *.py` \ --external-runner '/usr/bin/python -m unittest' Signed-off-by: Cleber Rosa <crosa@redhat.com>
|
Closing in favor of #1020 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the safe(r) test loader mechanism was introduced in the
avocado.core.loadermodule, it was written specifically to address Avocado's own needs (that is,avocado.Testbased test classes).Now, we want to:
$ avocado list --unsafeor similarThe first step is to abstract and isolate the original safe loader code, which is done and this PR in the form of the
avocado.core.safeloadermodule. Then, as a PoC, we deliver a contrib script that makes use of this new module and finds unittests on Python source code files.This brings us to an interesting situation, where, although not without flaws or limitations, Avocado can test itself, which was one of the original goals of the project. A sample session / command line would look like this:
Currently, this reveals a number of (simple) bugs in our unittests, mostly related to to file paths, and brings the following results:
For functional tests, it brings the following results: