Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: inspekt lint failure when passed invalid path #17

Closed
wants to merge 1 commit into from

Conversation

sanketsudake
Copy link

Description:
When inspekt lint fired with invalid path it hits type error.
As linter.check() return None, comparison between bool and None occurs.

Repro step:
Try,
inspekt lint random_string

Description:
When inspekt lint fired with invalid path it hits type error.
As linter.check() return None, comparison between bool and None occurs.

Repro step:
Try, inspekt lint random_string
@ldoktor
Copy link
Contributor

ldoktor commented Dec 6, 2015

@Tripples yep, I know this issue (and I'm sorry I forgot to send the version I'm using). This solution works fine, although is quite hard to understand the failure, I put log.warning(...) in case the path returned invalid result and I think it improves the results. Anyway I'm open to discussion, what do you think?

@sanketsudake
Copy link
Author

Yes, I agree putting log.warning is required here, though missed it. If you already have solution implemented, please update code. :-)

@ldoktor
Copy link
Contributor

ldoktor commented Dec 7, 2015

Hello @Tripples I sent my version, it uses a different approach but should also work. Thank you for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants