Parallel lint #35
Closed
Parallel lint #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lint check is by far the lengthiest static code check on my workflow. Let's make it run in parallel and save some precious time. I reckon this could and should be done at a different level, and also available for other checks (such as style, indent, license, etc). Also, alternative implementations, moving the file check to the command module (LintCommand) have been suggested, and may make more sense with a solution that works for style, indent, license, etc. Those can indeed follow up this version from their original authors. Signed-off-by: Cleber Rosa <crosa@redhat.com>
clebergnu
force-pushed
the
pylint_parallel
branch
from
3d87493
to
1d0a501
Compare
|
Closing in favor of #36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lint check is by far the lengthiest static code check on my
workflow. Let's make it run in parallel and save some precious time.
I reckon this could and should be done at a different level, and also
available for other checks (such as style, indent, license, etc).
Also, alternative implementations, moving the file check to the
command module (LintCommand) have been suggested, and may make more
sense with a solution that works for style, indent, license, etc.
Those can indeed follow up this version from their original authors.
Signed-off-by: Cleber Rosa crosa@redhat.com
Change from RFC (#32):