Reenable E402 and support for multiple paths #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, removing the |
This commit adds support to specify multiple files. The intention is to enable users to execute "inspektor style -- `git ls-files`" instead full directory scan. The problem with directory scan is it descends to submodules and also corrupts the "git rerere" cache. Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
|
@lmr what do you say about the multi-path support? |
|
Oh, true. I think it's great. I'm going to re-read the patch and merge soon enough. |
|
Looks good. Let me test this here. |
lmr
added a commit
that referenced
this pull request
Mar 2, 2015
Reenable E402 and support for multiple paths
|
Thanks @ldoktor ! |
|
Now, directory scan has to be fixed. |
|
What is wrong with the directory scan? |
|
From your commit comment: |
|
Well I'm not sure you have an easy way to fix this. You can either skip |
|
Yep, I'm looking at ignoring |
|
One could argue, how about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @lmr,
I looked again at the E402 problem and the latest PEP8 update fixes the issue with E402 being incorrectly detect by PEP8 when used as module. I think we should re-enable it again (there are couple of nasty modules in avocado, thought, but no false-positives).
The second commit is because I had my
git rererepoisoned by inspektor. It's really better to usegit ls-filesand check only the ones which are in this repository, rather than full recursive check.Kind reagards,
Lukáš