This repository has been archived by the owner on Nov 27, 2018. It is now read-only.
Major refactoring #185
Merged
Major refactoring #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng, updating `array.limit()` to halt iteration at the end of the array
…for easy chaining of handlers (paradigm shift from observer oriented chaining)
…ta.generate()` to use the appropriate record key (instead of concatenating the parent.id)
…ted the following methods to return a promise: `data.batch()`, `data.crawl()`, `data.del()`, `data.generate()`, `data.set()` & `data.sync()`, updated `data.generate()` to accept a String retrieve or Array to batch records, fixed `promise.resolve()` & `promise.reject()` to resolve on the next tick, updated `promise` unit tests Fixing a conditional statement
…a.del()`, `data.generate()`, `data.set()`, `data.setUri()`& `data.sync()` because they return Promises Fixing data store method linking via `Promises` Alignment Alignment
ghost
assigned
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
array.each()to not set an unneeded variable while iteratingarray.limit()to halt iteration at the end of the Arrayclient.jsonp()&client.request()to return aPromisestring.trim()executionsdata.batch()to be aware ofdata.leafs[]data.generate()to use the appropriate record key (instead of concatenating the parent.id)data.max&data.maxDepthpropertiesPromise:data.batch(),data.crawl(),data.del(),data.generate(),data.set(),data.setUri()&data.sync()futureparameter fromdata.batch(),data.crawl(),data.del(),data.generate(),data.set(),data.setUri()&data.sync(); this is an API revision / regression from 3.3.x syntaxdata.generate()to accept a String retrieve or Array to batch recordspromise.resolve()&promise.reject()to reconcile on the next tickpromiseunit testsdata.depth&data.maxDepthto control recursive API consumption