Repackaging with module syntax #9

avoidwork · 2022-08-27T14:02:05Z

Rewriting as an ES module
window decoration changed from router() to domRouter.router()
Updating build to use rollup
Updating README.md
Adding a changelog
Re-implementing functional testing with nightwatch.js

/Users/jason/.nvm/versions/node/v18.6.0/bin/npm run build

> dom-router@5.0.0 build
> npm run lint && rm -rf dist/* && npm run rollup && npm run ui


> dom-router@5.0.0 lint
> eslint *.js src/*.js tests/specs/basic/router.js


> dom-router@5.0.0 rollup
> rollup --config


./src/router.js → dist/dom-router.cjs.js, dist/dom-router.esm.js, dist/dom-router.esm.min.js, dist/dom-router.js, dist/dom-router.min.js, tests/specs/basic/www/dom-router.js...
created dist/dom-router.cjs.js, dist/dom-router.esm.js, dist/dom-router.esm.min.js, dist/dom-router.js, dist/dom-router.min.js, tests/specs/basic/www/dom-router.js in 286ms

> dom-router@5.0.0 ui
> npm run nightwatch-dirs && npm run nightwatch


> dom-router@5.0.0 nightwatch-dirs
> mkdir -p tests/page-objects && mkdir -p tests/custom-commands && mkdir -p tests/custom-assertions && mkdir -p tests/specs/basic


> dom-router@5.0.0 nightwatch
> npm run nightwatch-chrome && npm run nightwatch-firefox


> dom-router@5.0.0 nightwatch-chrome
> nightwatch tests/specs/basic/router.js --env chrome


[Tabbed UI Tests] Test Suite
────────────────────────────────────────────────────────
ℹ Connected to ChromeDriver on port 9515 (756ms).
  Using: chrome (104.0.5112.101) on MAC OS X.


  Running Default starting state - returns #main:
───────────────────────────────────────────────────────────────────────────────────────────────────
  ✔ Element <body> was visible after 19 milliseconds.
  ✔ Testing if element <#main> is visible (14ms)
  ✔ Testing if element <#settings> is not visible (12ms)
  ✔ Expected current url to end with: "#main" (3ms)

OK. 4 assertions passed. (53ms)

  Running Click tabbed navigation - returns #settings/billing:
───────────────────────────────────────────────────────────────────────────────────────────────────
  ✔ Element <body> was visible after 8 milliseconds.
  ✔ Testing if element <#settings> is visible (539ms)
  ✔ Testing if element <#billing> is visible (21ms)
  ✔ Testing if element <#password> is not visible (17ms)
  ✔ Testing if element <#main> is not visible (12ms)
  ✔ Expected current url to end with: "#settings/billing" (2ms)

OK. 6 assertions passed. (634ms)

> dom-router@5.0.0 nightwatch-firefox
> nightwatch tests/specs/basic/router.js --env firefox


[Tabbed UI Tests] Test Suite
────────────────────────────────────────────────────────
ℹ Connected to GeckoDriver on port 4444 (2194ms).
  Using: firefox (104.0) on MAC.


  Running Default starting state - returns #main:
───────────────────────────────────────────────────────────────────────────────────────────────────
  ✔ Element <body> was visible after 27 milliseconds.
  ✔ Testing if element <#main> is visible (17ms)
  ✔ Testing if element <#settings> is not visible (11ms)
  ✔ Expected current url to end with: "#main" (3ms)

OK. 4 assertions passed. (64ms)

  Running Click tabbed navigation - returns #settings/billing:
───────────────────────────────────────────────────────────────────────────────────────────────────
  ✔ Element <body> was visible after 15 milliseconds.
  ✔ Testing if element <#settings> is visible (542ms)
  ✔ Testing if element <#billing> is visible (19ms)
  ✔ Testing if element <#password> is not visible (16ms)
  ✔ Testing if element <#main> is not visible (12ms)
  ✔ Expected current url to end with: "#settings/billing" (2ms)

OK. 6 assertions passed. (646ms)

Process finished with exit code 0

…al link inclusion

…equential execution

avoidwork added 11 commits August 26, 2022 23:15

Work in progress

1cc8843

Removing contents of ./lib, fleshing out Router update

2e9387c

Adding missed files in previous commit

3deca12

Updating sweep() such that the DOM mutations happen on a render frame

31eed0e

Erasing contents of ./dist when npm:build is executed

4dfeba5

Renaming export to match previous versions

347804d

Fixing typo in selectorHasHash constant

2472494

Updating README.md

f9ef58b

Adding the test file to the rollup config

61f6272

Compacting the dist files again

183aebe

Finishing rewrite of load() which fixes a regression from last version

a25a400

avoidwork self-assigned this Aug 27, 2022

avoidwork added 10 commits August 27, 2022 10:05

Removing unneeded dev dependencies & adding changelog

ee9eec8

Generating a CHANGELOG.md

50358a6

Updating rollup.config.js to produce the expected outputs in ./dist

846558d

Rewriting parts of rollup config to be DRY

663b41c

Initial changes to update testing (WIP)

7b71d48

Updating lint task to include test runner file (WIP / fails)

deade10

Updating test HTML file

a7c9e39

Fixing selectorHasHash such that it's "starts with" to avoid extern…

ca8facb

…al link inclusion

Implementing nightwatch functional tests

f139f85

Removing safari from nightwatch config, creating more scripts for s…

397f061

…equential execution

avoidwork merged commit e189447 into master Aug 27, 2022

avoidwork deleted the repackage branch August 27, 2022 17:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Repackaging with module syntax #9

Repackaging with module syntax #9

avoidwork commented Aug 27, 2022 •

edited

Repackaging with module syntax #9

Repackaging with module syntax #9

Conversation

avoidwork commented Aug 27, 2022 • edited

avoidwork commented Aug 27, 2022 •

edited