Reducing code

avoidwork · Dec 9, 2018 · 31bc3eb · 31bc3eb
1 parent 9576b00
commit 31bc3eb
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 64 deletions.
diff --git a/lib/tiny-lru.js b/lib/tiny-lru.js
@@ -12,32 +12,29 @@
 (function (global) {
 	const empty = null;
 
-	function link (item, key, a, b) {
-		item[a] = key;
+	function link (item, key) {
+		item.next = key;
 
-		if (item[b] === key) {
-			item[b] = empty;
+		if (item.previous === key) {
+			item.previous = empty;
 		}
 	}
 
-	function reset () {
-		this.cache = {};
-		this.first = empty;
-		this.last = empty;
-		this.length = 0;
-
-		return this;
-	}
-
 	class LRU {
 		constructor (max, ttl) {
+			this.cache = {};
+			this.first = empty;
+			this.last = empty;
+			this.length = 0;
 			this.max = max;
 			this.ttl = ttl;
-			reset.call(this);
 		}
 
 		clear () {
-			reset.call(this);
+			this.cache = {};
+			this.first = empty;
+			this.last = empty;
+			this.length = 0;
 
 			return this;
 		}
@@ -46,18 +43,6 @@
 			return this.remove(key);
 		}
 
-		dump () {
-			return JSON.stringify({
-				cache: this.cache,
-				first: this.first,
-				last: this.last,
-				length: this.length,
-				max: this.max,
-				notify: this.notify,
-				ttl: this.ttl
-			});
-		}
-
 		evict () {
 			this.remove(this.last, true);
 
@@ -85,8 +70,6 @@
 			return key in this.cache;
 		}
 
-		onchange () {}
-
 		remove (key, bypass = false) {
 			let result;
 
@@ -128,7 +111,7 @@
 
 					item.next = empty;
 					item.previous = this.first;
-					link(this.cache[this.first], key, "next", "previous");
+					link(this.cache[this.first], key);
 
 					if (n !== empty && n !== this.first) {
 						if (p !== empty) {
@@ -160,7 +143,7 @@
 				}
 
 				if (this.first !== empty && this.first !== key) {
-					link(this.cache[this.first], key, "next", "previous");
+					link(this.cache[this.first], key);
 				}
 			}
 

diff --git a/lib/tiny-lru.min.js b/lib/tiny-lru.min.js
diff --git a/lib/tiny-lru.min.js.map b/lib/tiny-lru.min.js.map
diff --git a/src/intro.js b/src/intro.js
@@ -3,19 +3,10 @@
 (function (global) {
 	const empty = null;
 
-	function link (item, key, a, b) {
-		item[a] = key;
+	function link (item, key) {
+		item.next = key;
 
-		if (item[b] === key) {
-			item[b] = empty;
+		if (item.previous === key) {
+			item.previous = empty;
 		}
 	}
-
-	function reset () {
-		this.cache = {};
-		this.first = empty;
-		this.last = empty;
-		this.length = 0;
-
-		return this;
-	}