Refactoring set() to avoid ops & fix an assignment

avoidwork · Dec 7, 2018 · 8b6719a · 8b6719a
1 parent 42536c7
commit 8b6719a
Show file tree

Hide file tree

Showing 6 changed files with 34 additions and 32 deletions.
diff --git a/lib/tiny-lru.js b/lib/tiny-lru.js
@@ -5,7 +5,7 @@
  * @copyright 2018
  * @license BSD-3-Clause
  * @link https://github.com/avoidwork/tiny-lru
- * @version 4.0.4
+ * @version 4.0.5
  */
 "use strict";
 
@@ -136,28 +136,29 @@
 
 		set (key, value, silent = false, bypass = false) {
 			if (bypass === true || this.has(key) === true) {
-				const item = this.cache[key],
-					left = item.next,
-					right = item.previous;
+				const item = this.cache[key];
 
 				item.value = value;
-				item.next = empty;
 
 				if (this.first !== key) {
+					const left = item.next,
+						right = item.previous;
+
+					item.next = empty;
 					item.previous = this.first;
 					link(this.cache[this.first], key, "next", "previous");
-				}
 
-				if (right !== empty && left !== empty && right !== item.previous) {
-					this.cache[right].next = left;
-				}
+					if (left !== empty && left !== this.first) {
+						if (right !== empty) {
+							this.cache[right].next = left;
+						}
 
-				if (left !== empty) {
-					this.cache[left].previous = right;
-				}
+						this.cache[left].previous = right;
+					}
 
-				if (this.last === key && item.previous !== empty) {
-					this.last = item.previous;
+					if (this.last === key) {
+						this.last = item.previous;
+					}
 				}
 			} else {
 				if (this.length === this.max) {

diff --git a/lib/tiny-lru.min.js b/lib/tiny-lru.min.js