Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add @sentry/browser #25

Merged
merged 1 commit into from
Jun 20, 2019
Merged

✨ Add @sentry/browser #25

merged 1 commit into from
Jun 20, 2019

Conversation

zmckinnon
Copy link
Contributor

@zmckinnon zmckinnon commented Jun 20, 2019 •
edited

justinryder
justinryder reviewed Jun 20, 2019
View reviewed changes
src/app/app.module.ts
@@ -26,6 +26,10 @@ import {DiscordEmbedModule} from './shared/discord-embed/discord-embed.module';
import {HomebrewSharingModule} from './homebrew-sharing/homebrew-sharing.module';
import {LoginModule} from './login/login.module';

import * as Sentry from '@sentry/browser';

Sentry.init({ dsn: 'https://af2b06560981446bb55f64b6f79fd520@sentry.io/1486249' });
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to consider moving the error utils to a package so we can have the helper methods that Jason wrote back for the twitch extension. We've made a few minor fixes in the copy the encounter builder has.

https://github.com/DnDBeyond/ddb-encounter-builder-client/blob/master/src/error/ErrorUtils.js

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will log this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See: #26

@zmckinnon zmckinnon mentioned this pull request Jun 20, 2019
Open
@zmckinnon zmckinnon self-assigned this Jun 20, 2019
@zmckinnon zmckinnon merged commit 05681bf into master Jun 20, 2019
@zhudotexe zhudotexe deleted the add-sentry-io branch July 31, 2019 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinryder justinryder justinryder approved these changes

@zhudotexe zhudotexe zhudotexe approved these changes

@madcowfred madcowfred Awaiting requested review from madcowfred

Assignees

@zmckinnon zmckinnon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zmckinnon @justinryder @zhudotexe