Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CH341A futher improvement -- to support MSVC build #1339

Closed
mcuee opened this issue Apr 9, 2023 · 6 comments
Closed

CH341A futher improvement -- to support MSVC build #1339

mcuee opened this issue Apr 9, 2023 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mcuee
Copy link
Collaborator

mcuee commented Apr 9, 2023

Other than #1336, the other main issue with #1215 is that it only supports libusb-1.0 API. Therefore the default Windows MSVC build will not work since it uses avrdude-libusb which only supports libusb-0.1 API.

It will be good to add support for MSVC build via avrdude-libusb.

@stefanrueger
Copy link
Collaborator

It is unclear to me what a path to solving this issue is. None of the current maintainers have given this priority, so it is unlikely to be fixed anytime soon. There are (literally) 15 open issues mentioning libusb. This particular one sounds to me that time might solve it, eg, once MSVC supports libusb-1.0. In which case doing nothing might be OK? I suggest closing as won't fix.

@mcuee
Copy link
Collaborator Author

mcuee commented Jun 2, 2023

@stefanrueger

I think it is okay for an issue (especially enhancement request, or low impact bug) to exist for long. In avrdude we have very old issues which no one is working on. Netheverless they are still valid issues.

As for MSVC build, right now it is the default Windows binary provided when releasing avrdude. And it is using avrdude specific avrdude-libusb which was very useful when libusb-1.0 library had major problems with libusb0.sys. With libusb-1.0.26 release (on 11-April-2022), I see less issues (but there are still some issues) with libusb.sys now.

We can swtich msvc build to use official libusb-1.0 project and then this issue and #968 can be closed. However, we should hear @mariusgreuel's opinion on this topic. Take note that #968 is not a critical issue and this #1339 is just an enhancement,

@mcuee
Copy link
Collaborator Author

mcuee commented Jun 2, 2023

@mcuee
Copy link
Collaborator Author

mcuee commented Jun 2, 2023

There are (literally) 15 open issues mentioning libusb.

https://github.com/avrdudes/avrdude/issues?q=is%3Aissue+is%3Aopen+libusb

I will explain one by one.

So in the end, only two issues are really related to the use of avrdude-libusb for MSVC build under Windows.

@mcuee
Copy link
Collaborator Author

mcuee commented Jun 2, 2023

There are two enhancement which may benefit avrdude project to bridge the difference between different platforms.

@stefanrueger
Copy link
Collaborator

@mcuee Thanks for analysing and closing some of the issues that no longer need attention.

@mcuee mcuee added the help wanted Extra attention is needed label Jun 24, 2023
@avrdudes avrdudes locked and limited conversation to collaborators Jun 24, 2023
@mcuee mcuee converted this issue into discussion #1440 Jun 24, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants