-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Flip 2 reset on exit #1102
Conversation
This makes it possible for the application to start immedeatly after the program has been loaded. Simply use '-E reset' or '-E noreset'. Default is no reset. Closes avrdudes#733
I have no idea why this doesn't build on the MacOS CI. It builds perfectly fine with no warnings on my mac using make. |
I've been using
|
No idea why the macOS github action build failed. I have no issues building this pull request.
|
That is strange. Are you using macports or homebrew? Can you just try using |
@mcuee I'm using brew. Here's the output when executing build.sh:
|
Glad that
|
@MCUdude
|
@MCUdude Seems like you missed to implement flip2_parseexitspecs for !defined(HAVE_LIBUSB). For some reason, the macos-x86_64 build has only libusb-1.0. That was probably not intentional, but it seems it now serves as a testcase for libusb-1.0 only builds :-). That said, other programmers just populate For instance, see https://github.com/avrdudes/avrdude/blob/main/src/micronucleus.c#L971-L984 |
Used when compiling without libusb. Print reasonable error instead
e1c75e8
to
e1a317c
Compare
Thanks for the hint @mariusgreuel! the CI compiles just fine now. Any thoughts regarding the documentation?
|
Very good PR.
I'd suggest to add a sentence at the end of the -E exitspecs[,exitspecs] explantion to the effect of All parallel programmers support the full set of exit specifications whilst Fun fact: This PR differs in its My little punctuation tic prefers
over https://github.com/MCUdude/avrdude/blob/e1a317c6704f21433329673bf1f6b12397d03ea7/src/flip2.c#L943 I know that Overall an excellent contribution, which we should merge (even if above isn't addressed). |
Do you want to do this yourself, or do you want me to give it a try? I'm not very familiar with texi, so it usually takes a while to figure out the formatting.
If you want, I can implement the linuxspi implementation (and test it before pushing).
No worries, I've just pushed a fix. |
Use the same implementation as linuxspi does, instead of the one suggested in avrdudes#733
I realized that the way linuxspi implemented exitspecs was more robust, so I borrowed that implementation instead. I've tested it, and it works, even with
Perhaps it would make sense to create a dedicated page for programmers that supports one or more exitspecs? |
I never knew this existed. Until now I only have known of avrdude.1 and doc/avrdude.texi. Looks like above link is a bit outdated... Is that html-tree created from avrdude.texi or from yet another independent docu source?
There aren't that many: I suspect
Neater if you do it as you will have a better grasp of the motivation and significance of this PR. My simple sentence might be on the terse side. |
in the -E exitspecs section. linuxspi and flip2 supports "-E reset" and "-E noreset".
Docs updated, please review 👍 |
This allows the application to start immediately after the program has been loaded. Simply use
-E reset
or-E noreset
. Default is no reset. Tested on my Xplained ATxmega256A3BU board.I've currently not added anything to the docs. The Flip 2 protocol is hardly even mentioned, and I'm not sure where to put the additional information that Flip2 supports
-E reset
.Closes #733