Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -xmode to switch PICkit4 and SNAP application modes #1596

Merged
merged 27 commits into from
Jan 3, 2024
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
e9685a0
Use libusb to switch a PICkit4 or SNAP to AVR mode
MCUdude Dec 18, 2023
2d68910
Fix case
MCUdude Dec 18, 2023
15154dd
implement -xmode=pic
MCUdude Dec 20, 2023
8d017c2
Print PIC switch info messages
MCUdude Dec 20, 2023
6afc703
Fix typo
MCUdude Dec 20, 2023
416e051
Rename SNAP and PICkit4 USB PID
MCUdude Dec 22, 2023
23818d6
Make it possible to enter avr mode even when the tool is in bootloade…
MCUdude Dec 25, 2023
28eaa44
Add -xmode to docs
MCUdude Dec 25, 2023
6edbf18
Tweak grammar
MCUdude Dec 25, 2023
2fc7826
Add -xmode support for pickit4_isp and snap_isp
MCUdude Dec 25, 2023
74c29f0
Don't print "unable to open port" error on pgm->open softfail
MCUdude Dec 25, 2023
244e8e1
Add const
MCUdude Dec 25, 2023
3b27fe4
Simplify SNAP/PICkit4 mode switching code
MCUdude Dec 25, 2023
42178e2
Formatting
MCUdude Dec 26, 2023
59dde79
Add extra argument to jtag3_open_common
MCUdude Dec 26, 2023
a88c5c1
Improve extended parameter parsing
MCUdude Dec 27, 2023
17a7853
Improve error message
MCUdude Dec 27, 2023
23ce3a4
Improve extended parameter parsing
MCUdude Dec 27, 2023
9920a23
Immediately exit after a mode switch
MCUdude Dec 27, 2023
8d7b7c4
Remove unnecessary line
MCUdude Dec 27, 2023
fc905fe
Add missing serial_close
MCUdude Dec 27, 2023
40f3553
Remove unnecessary else
MCUdude Dec 28, 2023
e7fb25c
Minor code tweaks
MCUdude Dec 28, 2023
f84bf23
Update docs
MCUdude Dec 28, 2023
4590e6a
Formatting
MCUdude Dec 29, 2023
8fcf72e
Improve external parameter parsing and error handling
MCUdude Jan 2, 2024
bc102f1
Remove unused parameter
MCUdude Jan 2, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/jtag3.c
Original file line number Diff line number Diff line change
Expand Up @@ -1585,18 +1585,18 @@ static int jtag3_parseextparms(const PROGRAMMER *pgm, const LISTID extparms) {
int sscanf_success = sscanf(extended_param, "vtarg=%lf", &vtarg_set_val);
PDATA(pgm)->vtarg_data = (double)((int)(vtarg_set_val * 100 + .5)) / 100;
if (sscanf_success < 1 || vtarg_set_val < 0) {
pmsg_error("invalid vtarg value '%s'\n", extended_param);
pmsg_error("invalid vtarg value %s\n", extended_param);
MCUdude marked this conversation as resolved.
Show resolved Hide resolved
rv = -1;
break;
}
PDATA(pgm)->vtarg_set = true;
continue;
}
// Get target voltage
else if(str_eq(extended_param, "vtarg")) {
else if(str_eq(extended_param, "vtarg"))
PDATA(pgm)->vtarg_get = true;
continue;
}
else
MCUdude marked this conversation as resolved.
Show resolved Hide resolved
break;
continue;
}
}

Expand Down