Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aliases): Merge AvroAliases annotation to AvroAlias #156

Merged
merged 1 commit into from
Aug 30, 2023
Merged

feat(aliases): Merge AvroAliases annotation to AvroAlias #156

merged 1 commit into from
Aug 30, 2023

Conversation

Chuckame
Copy link
Contributor

@Chuckame Chuckame commented Aug 25, 2023 •
edited

  • Now, to have multiple aliases, just annotate like @AvroAlias("alias1", "alias2", "alias3") as it is now a vararg parameter
  • updated to kotlin 1.9 to have @Repeatable working
  • deprecated @AvroAliases in favor of @AvroAlias
  • Closes Remove Aliases, prior to Alias with vararg #155

@Chuckame Chuckame changed the title feat(aliases)!: Merge AvroAliases annotation to AvroAlias feat(aliases): Merge AvroAliases annotation to AvroAlias Aug 25, 2023
@Chuckame
Copy link
Contributor Author

@thake Is it ok for you, and do you feel comfortable by changing from AvroAlias(val value: String) to AvroAlias(vararg val value: String) with only deploying a new feature (still 1.x) and not a breaking change (in 2.x) ?

@thake
Copy link
Member

thake commented Aug 29, 2023

@Chuckame, I'm comfortable with this approach. It should be highlighted in the release notes, though.

thake
thake requested changes Aug 29, 2023
View reviewed changes
build.gradle.kts Outdated Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
src/main/kotlin/com/github/avrokotlin/avro4k/annotations.kt Outdated Show resolved Hide resolved
@Chuckame
feat(aliases): Merge AvroAliases annotation to AvroAlias
ab44be6 
- Now, to have multiple aliases, just annotate like `@AvroAlias("alias1", "alias2", "alias3")` as it is now a vararg parameter
- updated to kotlin 1.9 to have `@Repeatable` working
- deprecated `@AvroAliases` in favor of `@AvroAlias`
- Removed non-working `@Language("json")` annotations
@Chuckame
Copy link
Contributor Author

@thake ok for you ?

@Chuckame Chuckame closed this Aug 30, 2023
@Chuckame
Copy link
Contributor Author

Let's m

@Chuckame Chuckame reopened this Aug 30, 2023
@Chuckame Chuckame merged commit dab6cf4 into avro-kotlin:main Aug 30, 2023
2 checks passed
@Chuckame Chuckame deleted the alias-fix branch January 31, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thake thake thake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Aliases, prior to Alias with vararg
2 participants
@Chuckame @thake