Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): Replace buildSrc by gradle's versionCatalogs #173

Merged
merged 2 commits into from
Jan 21, 2024

Conversation

Chuckame
Copy link
Contributor

Removed the custom buildSrc in favor of gradle's versionCatalogs.

I also removed sksamuel as he is not a maintainer of this avro4k library.

@Chuckame Chuckame requested a review from thake January 21, 2024 13:17
Copy link
Member

@thake thake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I was thinking about this change but never had the time to go for it.

build.gradle.kts Show resolved Hide resolved
build.gradle.kts Show resolved Hide resolved
@thake thake merged commit f0cbc8b into avro-kotlin:main Jan 21, 2024
1 check passed
@Chuckame
Copy link
Contributor Author

Just a side note, I would prefer that you approve instead of merging yourself my PR 😄 I usually read again what I've did before merging to be sure that I missed nothing !

@Chuckame Chuckame deleted the reflectionlass-schema branch January 22, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants