Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed length char array results in malformed path string for WMM.COF file #74

Closed
patkenneally opened this issue Jan 6, 2023 · 0 comments · Fixed by #75
Closed

Fixed length char array results in malformed path string for WMM.COF file #74

patkenneally opened this issue Jan 6, 2023 · 0 comments · Fixed by #75
Assignees
Labels
bug Something isn't working

Comments

@patkenneally
Copy link
Contributor

Describe the bug
The fileName local variable in MagneticFieldWMM::initializeWmm is a fixed length char array. When basilisk is located in a folder tree depth whith a path string length of great than the fixed 100 characters, the module fails to find the WMM.COF because the path is malformed (cut off).

To Reproduce
Steps to reproduce the behavior:

  1. Install basilisk in a directory structure where the path to the WMM.COF file is more than 100 characters in length.
  2. Build and run all tests and those using MagneticFieldWMM will fail.

Expected behavior
The module to find WMM.COF regardless of location of basilisk on the OS. Tests to pass

Desktop (please complete the following information):

  • OS: Macos
  • Version 12.6.1
  • Python version 3.9.15

Additional context
I realize that any solution might not sufficiently account for the OS limits on path length. That's a much deeper and more nuanced topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant