Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization no longer uses a fixed size buffer. #76

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hhugo
Copy link

@hhugo hhugo commented Nov 4, 2023

This is still WIP has I'm not sure we want the dependency on ctypes.foreign

@sim642
Copy link
Contributor

sim642 commented Nov 4, 2023

In #65 I did something like this as well but it's been a while.

@hhugo
Copy link
Author

hhugo commented Nov 4, 2023

In #65 I did something like this as well but it's been a while.

Thanks for the pointer.
Do you still have interest to push this through? If so, I'm happy to do some reviews

@sim642
Copy link
Contributor

sim642 commented Nov 5, 2023

Do you still have interest to push this through?

Depends on whether there really is interest for it. This PR is a a subset of what I tried to do, so this might be easier to push through first. I also wanted to streaming parse from file without going through a fixed-size/dynamic buffer to minimize overhead, but I think there were some problems with doing it cleanly.

I'm not sure we want the dependency on ctypes.foreign

That's the concern I also had. There might be (at least ideally) a way around it: yallop/ocaml-ctypes#711.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants