Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Path from comment to After Element HTML #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NathanDayFE
Copy link

resolves #33

@NathanDayFE
Copy link
Author

@avstudnitz Any chance of having this PR reviewed?

@NathanDayFE
Copy link
Author

@avstudnitz Apologies for double tagging but is there any chance of having this PR reviewed and merged?

@lefte
Copy link

lefte commented Jan 19, 2024

Hello, future search engine result people such as myself! In case you get to this result via some form of a Magento error in management about Phrase and getText() as a string, know that this patch can fix your issue until @avstudnitz merges in this commit or fixes it another way. Here's how I solved it:

  1. Modify your composer.json file by adding the patch repository to the repositories section:
    "repositories": {
         "avsscopehintpatch": {
            "type": "git",
            "url": "https://github.com/NathanDayFE/AvS_ScopeHint2"
        },
        ...any other repos here
    }
  1. Require the package with this:
    "require": {
        "avstudnitz/scopehint2": "dev-comment-phrase#cb2cfa4",
        ....any other packages here
    }

ℹ️ Note: The dev- in the package version is composer magic to let it know to use the branch instead of a release number, and the #cb2cfa4 is the hash of the specific commit in the new repo. The commit is not required, but I like to use it for specificity, and so you don't have to use composer clear-cache when new commits are added.

  1. Update composer using: composer upgrade avstudnitz/scopehint2
  2. Run bin/magento setup:upgrade to finalize
  3. Set yourself a calendar reminder to check back on this patch in a month to see if you can use the standard install instead because it's been officially patched in
  4. Enjoy Magento
  5. Repeat 5 & 6 as needed

Thanks again @NathanDayFE for the work on this patch!

@lefte lefte mentioned this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments not translated
2 participants