Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laravel 7 and regular update #11

Merged
merged 9 commits into from
Jun 23, 2020
Merged

Laravel 7 and regular update #11

merged 9 commits into from
Jun 23, 2020

Conversation

tarampampam
Copy link
Contributor

@tarampampam tarampampam commented Jun 22, 2020 •
edited
Loading

Q A
Bug fix? No
New feature? No

Description

Changed

  • Maximal illuminate/* packages version now is 7.*
  • CI completely moved from "Travis CI" to "Github Actions" (travis builds disabled)
  • Minimal required PHP version now is 7.2
  • Updated PHPDoc annotations
  • Minimal phpunit/phpunit version now is ~7.2 (reason - class PHPUnit\Framework\MockObject\MockObject)
  • Class AvtoDev\FirebaseNotificationsChannel\Exceptions\CouldNotSendNotification finalized
  • Method AvtoDev\FirebaseNotificationsChannel\FcmChannel::send now returns void
  • Methods in AvtoDev\FirebaseNotificationsChannel\PlatformSettings\*::set* now returns void

Added

  • PHP 7.4 is supported now

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I wrote unit tests for my code (if tests is required for my changes)
  • I have made changes in CHANGELOG.md file

@tarampampam tarampampam changed the title Around-code changes made Laravel 7 and regular update Jun 22, 2020
@tarampampam tarampampam requested a review from jetexe June 22, 2020 15:23
@tarampampam tarampampam self-assigned this Jun 22, 2020
@tarampampam tarampampam added the enhancement New feature or request label Jun 22, 2020
@tarampampam tarampampam marked this pull request as ready for review June 22, 2020 15:29
@tarampampam tarampampam merged commit 5e00575 into master Jun 23, 2020
@tarampampam tarampampam deleted the laravel-7-and-regular-update branch June 23, 2020 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jetexe jetexe jetexe approved these changes

Assignees

@tarampampam tarampampam

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tarampampam @jetexe