Skip to content
This repository has been archived by the owner on May 25, 2020. It is now read-only.

Package has totally rewritten (v3) #26

Merged
merged 65 commits into from Jan 15, 2020
Merged

Package has totally rewritten (v3) #26

merged 65 commits into from Jan 15, 2020

Conversation

tarampampam
Copy link
Contributor

@tarampampam tarampampam commented Jan 9, 2020

Q A
Bug fix? No
New feature? Yes

Description

Changed

  • Package was totally rewrote

Added

  • Events for interaction with worker loop:
    • BeforeLoopStartedEvent
    • BeforeLoopIterationEvent
    • BeforeRequestHandlingEvent
    • AfterRequestHandlingEvent
    • AfterLoopIterationEvent
    • AfterLoopStoppedEvent
  • Listeners:
    • BindRequestListener
    • ClearInstancesListener
    • CloneConfigListener
    • FixSymfonyFileValidationListener
    • ForceHttpsListener
    • InjectStatsIntoRequestListener
    • RebindHttpKernelListener
    • RebindRouterListener
    • RebindViewListener
    • ResetDbConnectionsListener
    • ResetProvidersListener
    • ResetSessionListener
    • RunGarbageCollectorListener
    • SetServerPortListener
    • UnqueueCookiesListener
  • Spiral\RoadRunner\PSR7Client instance in application containers (closes Access to PSR7Client #21)
  • Environment variable APP_REFRESH supports
  • Package configuration file
  • PHP 7.4 supports

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I wrote unit tests for my code (if tests is required for my changes)
  • I have made changes in CHANGELOG.md file

@tarampampam tarampampam self-assigned this Jan 9, 2020
@codecov-io
Copy link

codecov-io commented Jan 14, 2020

Codecov Report

Merging #26 into master will increase coverage by 7.75%.
The diff coverage is 97.69%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #26      +/-   ##
===========================================
+ Coverage     89.95%   97.7%   +7.75%     
- Complexity      101     105       +4     
===========================================
  Files             9      23      +14     
  Lines           239     262      +23     
===========================================
+ Hits            215     256      +41     
+ Misses           24       6      -18
Impacted Files Coverage Δ Complexity Δ
src/Listeners/RunGarbageCollectorListener.php 0% <0%> (ø) 1 <1> (?)
src/Listeners/RebindRouterListener.php 100% <100%> (ø) 5 <5> (?)
src/Listeners/BindRequestListener.php 100% <100%> (ø) 3 <3> (?)
src/Listeners/RebindHttpKernelListener.php 100% <100%> (ø) 2 <2> (?)
src/Listeners/SetServerPortListener.php 100% <100%> (ø) 6 <6> (?)
src/Events/AfterLoopIterationEvent.php 100% <100%> (ø) 4 <4> (?)
src/Listeners/ClearInstancesListener.php 100% <100%> (ø) 4 <4> (?)
src/Events/AfterLoopStoppedEvent.php 100% <100%> (ø) 2 <2> (?)
src/Listeners/ForceHttpsListener.php 100% <100%> (ø) 4 <4> (?)
src/Listeners/RebindViewListener.php 100% <100%> (ø) 2 <2> (?)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57f41e8...3d4c202. Read the comment docs.

@tarampampam tarampampam changed the title WIP: Totally rewritten - v3 Package totally rewritten (v3) Jan 14, 2020
@tarampampam
Copy link
Contributor Author

Also this PR closes PRs #24 and #25

@tarampampam
Copy link
Contributor Author

Add closes issue #22

@tarampampam tarampampam mentioned this pull request Jan 14, 2020
@tarampampam
Copy link
Contributor Author

tarampampam commented Jan 14, 2020

And closes #21 (woooof!)

@tarampampam tarampampam changed the title Package totally rewritten (v3) Package has totally rewritten (v3) Jan 15, 2020
src/Events/BeforeLoopIterationEvent.php Show resolved Hide resolved
bin/rr-worker Show resolved Hide resolved
bin/rr-worker Show resolved Hide resolved
src/ServiceProvider.php Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Access to PSR7Client
4 participants