v4 (major update) #7
Conversation
…s-laravel into regular-update
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
==========================================
+ Coverage 93.67% 100% +6.32%
+ Complexity 249 111 -138
==========================================
Files 24 16 -8
Lines 411 251 -160
==========================================
- Hits 385 251 -134
+ Misses 26 0 -26
Continue to review full report at Codecov.
|
| $this->code = $code; | ||
| $this->name = $name; | ||
|
|
||
| foreach ($areas as $area) { |
There was a problem hiding this comment.
Почему foreach не заменить на
$this->areas = $areas;а в CadastralDistricts сразу не прописать ключи?
There was a problem hiding this comment.
Because $this->areas used as index, where key is area code, and value is area object (areas order is not important in this case)
| $areas = []; | ||
|
|
||
| foreach ($datum['areas'] as $area_info) { | ||
| $areas[] = new CadastralArea($area_info['code'], $area_info['name']); |
There was a problem hiding this comment.
Почему не
$areas[$area_info['code']] = new CadastralArea($area_info['code'], $area_info['name']);There was a problem hiding this comment.
Разделение ответственности отсутствие зависимости от порядка (ключей) для CadastralDistrict в array $areas
| { | ||
| return (string) Json::encode($this->toArray(), $options); | ||
| } | ||
| } |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
You always can do something like this:
\count($district->getAreas());keep it simple =)
|
|
||
| // Multiple dots replace with single | ||
| return (string) \preg_replace('/\.+/', '.', $value); | ||
| } |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| */ | ||
| public function __construct(StaticReferenceInterface $static_reference) | ||
| { | ||
| $counter = 0; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
May be
foreach (\array_values((array) $static_reference->getData(true)) as $key => $datum) {
$this->entities[$key] = new VehicleRegistrationAction($datum['codes'], $datum['description']);
...
}There was a problem hiding this comment.
Не думаю, что здесь это на что-либо влияет (пример @Reallife потребует дополнительный вызов array_values)
src/ServiceProvider.php
Outdated
| } | ||
| } | ||
| $this->app->singleton(CadastralDistricts::class, static function (): CadastralDistricts { | ||
| return new References\CadastralDistricts(StaticReferencesData::cadastralDistricts()); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| parent::setUp(); | ||
|
|
||
| /** @var m\MockInterface|StaticReferenceInterface $static_reference */ | ||
| $static_reference = m::mock(StaticReferenceInterface::class) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
- выносить в абстракт 2 строчки?
- какие данные и из каких пропертей?
Description
Changed
illuminate\*packages version now is^5.5illuminate\*packages version now is~6.0References\ReferenceInterfacenow extendsIteratorAggregate, Countable, Illuminate\Contracts\Support\Arrayableand not contains any methodshas*methods (indexes used)Added
References\CadastralDistrictsReferences\SubjectCodesReferences\VehicleCategoriesReferences\VehicleFineArticlesReferences\VehicleRegistrationActionsReferences\VehicleRepairMethodsReferences\VehicleTypesReferences\Entities\EntityInterface(extendsIlluminate\Contracts\Support\Support\Arrayable)References\Entities\CadastralAreaReferences\Entities\CadastralDistrictReferences\Entities\SubjectCodesInfoReferences\Entities\VehicleCategoryReferences\Entities\VehicleFineArticleReferences\Entities\VehicleRegistrationActionReferences\Entities\VehicleRepairMethodReferences\Entities\VehicleTypeRemoved
AutoCategoriesFacade,AutoFinesFacade,AutoRegionsFacade,CadastralRegionsFacade,RegistrationActionsFacade,RepairMethodsFacade)References\AbstractReferenceReferences\AbstractReferenceEntryReferences\AutoCategories\AutoCategoriesReferences\AutoCategories\AutoCategoryEntryReferences\AutoFines\AutoFineEntryReferences\AutoFines\AutoFinesReferences\AutoRegions\AutoRegionEntryReferences\AutoRegions\AutoRegionsReferences\CadastralDistricts\CadastralDistrictEntryReferences\CadastralDistricts\CadastralDistrictsReferences\CadastralDistricts\CadastralRegionEntryReferences\CadastralDistricts\CadastralRegionsReferences\RegistrationActions\RegistrationActionEntryReferences\RegistrationActions\RegistrationActionsReferences\RepairMethods\RepairMethodsReferences\RepairMethods\RepairMethodsEntryReferences\ReferenceEntryInterfaceReferences\Traits\TransliterateTraitChecklist