Change method userReportMake in ClientInterface

[gomzyakov]

Description

Added

• Class ReportMakeParams to build make-report parameters
• Optional parameter idempotenceKey for report-make requests

Changed

• Method userReportMake in ClientInterface (now he takes ReportMakeParams as parameter)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I wrote unit tests for my code (if tests is required for my changes)
• I have made changes in CHANGELOG.md file

[codecov-io]

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master       #17   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       461       479   +18     
===========================================
  Files             33        34    +1     
  Lines           1137      1180   +43     
===========================================
+ Hits            1137      1180   +43     

Flag	Coverage Δ	Complexity Δ
#php	100.00% <100.00%> (ø)	479.00 <28.00> (+18.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
src/Client.php	100.00% <100.00%> (ø)	45.00 <6.00> (-4.00)
src/Params/ReportMakeParams.php	100.00% <100.00%> (ø)	22.00 <22.00> (?)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c54c935...46fe77f. Read the comment docs.

[tarampampam]

Can you write tests for ReportMakeParams class too?

[gomzyakov]

@tarampampam

Can you write tests for ReportMakeParams class too?

Yes, of course. Since your review, I:

• Rename ReportMakeParams to ReportMakeRequest (
• Wrote tests for ex-ReportMakeParams
• Move some logic to ReportMakeRequest::getBodyObject method

Its OK?

Notice: I forgot to put the "Draft" tag in the title of the PR. An hour ago, the PR was unfinished, sorry)

[tarampampam]

Looks good! But:

• ReportMakeRequest your class is not request. It seems like parameters, so, rename it back, please
• Do not keep logic in parameters wrapper - this is a bad practice.

And last - documentation. Code samples (in readme file, for example) must be updatated too

[gomzyakov]

Looks good! But:

• ReportMakeRequest your class is not request. It seems like parameters, so, rename it back, please
• Do not keep logic in parameters wrapper - this is a bad practice.

And last - documentation. Code samples (in readme file, for example) must be updatated too

All comments considered

[tarampampam]

Please, follow PR comments

[tarampampam]

"Parameter classes finalization" versus "Parameter interfaces with defined getters". Friendly ping for @eldario

[eldario]

@tarampampam @gomzyakov

I don't see the need to use interfaces for the ReportMakeParams. Therefore, I propose to prevent them from being overridden in child classes by adding Final to the class.

[gomzyakov]

@tarampampam I ran the feature-tests again. All OK.

[tarampampam]

👍 Great thanks for your contribution!