Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactory ClientInterface & Client class #22

Merged
merged 65 commits into from
Oct 22, 2020
Merged

Refactory ClientInterface & Client class #22

merged 65 commits into from
Oct 22, 2020

Conversation

gomzyakov
Copy link
Contributor

@gomzyakov gomzyakov commented Oct 14, 2020 •
edited
Loading

Description

Changed

  • Refactory ClientInterface & Client class

Fixes #20

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I wrote unit tests for my code (if tests is required for my changes)
  • I have made changes in CHANGELOG.md file

gomzyakov and others added 20 commits October 13, 2020 11:36
Add ReportRefreshParams
0b56d0b
@gomzyakov
Merge branch 'master' of https://github.com/avtocod/b2b-api-php into …
4effde6 
…refactory-client
@gomzyakov
Update tests for method userReportRefresh & change README.md
8fde271
@gomzyakov
Add AbstractListParams
2565ed2
@gomzyakov
Add ReportTypesParams & ReportsParams
a1ac2f6
@gomzyakov
Realize methods userReportTypes & userReports
2201587
@gomzyakov
Update method user()
a827942
@gomzyakov
Update method devPing()
d5d1441
@gomzyakov
Update method userReport()
da45545
@gomzyakov
Change userBalance() method signature
7a03cde
@gomzyakov
Change devToken() method signature
54f1987
@gomzyakov
Rename param-objects
5c8cdc2
@gomzyakov
Add UserReportParamsTest
45631c5
@gomzyakov
Add UserReportRefreshParamsTest
1ec0d6b
@gomzyakov
Add UserParamsTest
94b3802
@gomzyakov
Add UserBalanceParamsTest
0b93799
@gomzyakov
Add DevPingParamsTest
562c01d
@gomzyakov
Add DevTokenParamsTest
ce126ab
@gomzyakov
Add UserReportsParamsTest
3c50a38
@gomzyakov
Add UserReportTypesParamsTest
39661ba
@gomzyakov gomzyakov marked this pull request as draft October 14, 2020 05:25
@codecov-io
Copy link

codecov-io commented Oct 14, 2020 •
edited
Loading

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##              master       #22    +/-   ##
============================================
  Coverage     100.00%   100.00%            
- Complexity       479       588   +109     
============================================
  Files             34        42     +8     
  Lines           1180      1338   +158     
============================================
+ Hits            1180      1338   +158
Flag Coverage Δ Complexity Δ
#php 100.00% <100.00%> (ø) 588.00 <137.00> (+109.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/Params/UserReportMakeParams.php 100.00% <ø> (ø) 22.00 <0.00> (?)
src/Client.php 100.00% <100.00%> (ø) 69.00 <52.00> (+24.00)
src/Params/DevPingParams.php 100.00% <100.00%> (ø) 3.00 <3.00> (?)
src/Params/DevTokenParams.php 100.00% <100.00%> (ø) 13.00 <13.00> (?)
src/Params/UserBalanceParams.php 100.00% <100.00%> (ø) 5.00 <5.00> (?)
src/Params/UserParams.php 100.00% <100.00%> (ø) 3.00 <3.00> (?)
src/Params/UserReportParams.php 100.00% <100.00%> (ø) 8.00 <8.00> (?)
src/Params/UserReportRefreshParams.php 100.00% <100.00%> (ø) 5.00 <5.00> (?)
src/Params/UserReportTypesParams.php 100.00% <100.00%> (ø) 24.00 <24.00> (?)
src/Params/UserReportsParams.php 100.00% <100.00%> (ø) 24.00 <24.00> (?)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a3aa2...166276b. Read the comment docs.

gomzyakov
gomzyakov commented Oct 14, 2020
View reviewed changes
src/Client.php Outdated Show resolved Hide resolved
@gomzyakov gomzyakov marked this pull request as ready for review October 14, 2020 07:26
gomzyakov
gomzyakov commented Oct 21, 2020
View reviewed changes
src/Client.php Outdated Show resolved Hide resolved
tarampampam
tarampampam suggested changes Oct 21, 2020
View reviewed changes
src/Client.php Outdated Show resolved Hide resolved
src/Client.php Outdated Show resolved Hide resolved
src/Client.php Outdated Show resolved Hide resolved
tarampampam
tarampampam suggested changes Oct 21, 2020
View reviewed changes
src/Client.php Outdated Show resolved Hide resolved
src/Client.php Outdated Show resolved Hide resolved
src/Client.php Outdated Show resolved Hide resolved
src/Client.php Outdated Show resolved Hide resolved
src/Client.php Outdated Show resolved Hide resolved
src/Params/DevPingParams.php Outdated Show resolved Hide resolved
gomzyakov and others added 4 commits October 21, 2020 22:42
@gomzyakov @tarampampam
Update method userBalance in Client
1af6853 
Co-authored-by: Paramtamtam <7326800+tarampampam@users.noreply.github.com>
@gomzyakov @tarampampam
Chose '_offset' over max() in Client::userReportTypes
a664a53 
Co-authored-by: Paramtamtam <7326800+tarampampam@users.noreply.github.com>
@gomzyakov @tarampampam
Chose '_offset' over max() in Client::userReports
d1a3c87 
Co-authored-by: Paramtamtam <7326800+tarampampam@users.noreply.github.com>
@gomzyakov
Update CHANGELOG.md
29caa24
tarampampam
tarampampam reviewed Oct 22, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
gomzyakov and others added 5 commits October 22, 2020 11:03
@gomzyakov @tarampampam
Update '_detailed' property logic in Client::userReport
ec83a0a 
Co-authored-by: Paramtamtam <7326800+tarampampam@users.noreply.github.com>
@gomzyakov @tarampampam
Update '_content' property logic in Client::userReport
185ae21 
Co-authored-by: Paramtamtam <7326800+tarampampam@users.noreply.github.com>
@gomzyakov
Fix params _content & _detailed logic
53a5878
@gomzyakov @tarampampam
Some fixes in CHANGELOG.md
cec58f7 
Co-authored-by: Paramtamtam <7326800+tarampampam@users.noreply.github.com>
@gomzyakov
Delete line from Fixed block in CHANGELOG.md
0ce812e
tarampampam
tarampampam suggested changes Oct 22, 2020
View reviewed changes
src/Client.php Outdated Show resolved Hide resolved
@tarampampam tarampampam merged commit bc8197e into avtocod:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldario eldario eldario approved these changes

@tarampampam tarampampam tarampampam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update all API clent methods parameters (a lot of params -> single params object)
4 participants
@gomzyakov @codecov-io @tarampampam @eldario