Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular update #7

Merged
merged 5 commits into from
Jan 22, 2020
Merged

Regular update #7

merged 5 commits into from
Jan 22, 2020

Conversation

tarampampam
Copy link
Contributor

@tarampampam tarampampam commented Jan 22, 2020

Q A
Bug fix? No
New feature? No

Description

Added

  • Tests running using GitHub Actions
  • phpstan configuration file with disabled checkGenericClassInNonGenericObjectType and checkMissingIterableValueType
  • PHP 7.4 tests using CI

Changed

  • StyleCI rules. Enabled: length_ordered_imports, disabled: alpha_ordered_imports
  • Updated dev-dependency versions
  • Anonymous functions now static (where this is possible)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I wrote unit tests for my code
  • I have made changes in CHANGELOG.md file

About your changes in CHANGELOG.md:

  • Add new version header like ## UNRELEASED, if it does not exists
  • Add description under added/changed/fixed sections
  • Add reference to closed issues [#000]
  • Add link to issue in the end of document

@tarampampam tarampampam self-assigned this Jan 22, 2020
@codecov-io
Copy link

codecov-io commented Jan 22, 2020

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master     #7   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity      457    457           
=======================================
  Files            33     33           
  Lines          1131   1131           
=======================================
  Hits           1131   1131
Impacted Files Coverage Δ Complexity Δ
src/Responses/UserReportRefreshResponse.php 100% <ø> (ø) 12 <0> (ø) ⬇️
src/Responses/UserReportTypesResponse.php 100% <ø> (ø) 16 <0> (ø) ⬇️
src/Responses/UserReportResponse.php 100% <ø> (ø) 12 <0> (ø) ⬇️
src/Responses/UserBalanceResponse.php 100% <ø> (ø) 13 <0> (ø) ⬇️
src/Responses/Entities/ReportState.php 100% <ø> (ø) 7 <0> (ø) ⬇️
src/Responses/UserResponse.php 100% <ø> (ø) 13 <0> (ø) ⬇️
src/Responses/UserReportsResponse.php 100% <ø> (ø) 15 <0> (ø) ⬇️
src/Responses/UserReportMakeResponse.php 100% <ø> (ø) 12 <0> (ø) ⬇️
src/Responses/Entities/ReportContent.php 100% <ø> (ø) 5 <0> (ø) ⬇️
src/Settings.php 100% <ø> (ø) 9 <0> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7270db8...e794813. Read the comment docs.

@tarampampam tarampampam merged commit 9fdd66a into master Jan 22, 2020
@tarampampam tarampampam deleted the update/regular branch January 22, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants