adding result parsing and Resourcifying to method_missing calls #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if results.is_a? JsonApiClient::ResultSet | ||
| results.map! do |result| | ||
| self.new(:client => result) | ||
| end |
There was a problem hiding this comment.
- will this affect
def findanddef where? - should this be a method to break it out and be used elsewhere?
There was a problem hiding this comment.
- They're defined in Queriable, so should not ever fall through to this.
- Oh, absolutely. this is a disaster. There needs to be a function that handles all client comm, but i don't have time to rearchitect the gem right now. I'll think about it over the weekend.
bluetwin
pushed a commit
that referenced
this pull request
Jul 24, 2015
adding result parsing and Resourcifying to method_missing calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now when there's a custom_function on the client, the Resource falls though to it and returns its results. That's annoying because those results are JsonApiClient objects. This fixes them to be JsonApiResource objects.