Fix errors for find #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 29, 2015 09:57
When doing a find, there cannot be any errors. We just need to default it to ActiveModel::Errors.
ApiErrors returns different things sometimes, and we cannot load some things using [] or {}, if it expected ActiveModel::Errors.
| @@ -45,7 +45,8 @@ def single_result(results) | |||
|
|
|||
| result.meta = results.meta | |||
|
|
|||
| result.errors = ApiErrors(results.errors) | |||
| # There will never be errors here but this provides a good default for forms | |||
| result.errors = ActiveModel::Errors.new(result) | |||
There was a problem hiding this comment.
since result is a Resource which has the include ActiveModel::Validations module, do we need this line?
There was a problem hiding this comment.
You are right, it is not required because we do the same defaulting in resource. I removed it.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing a find, there cannot be any errors. We just need to default it to ActiveModel::Errors.
ApiErrors returns different things sometimes, and we cannot load some things using [] or {}, if it expected ActiveModel::Errors.