When we try to save/update an object, we should return an error statu… #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s code instead of an exception if the server throws
| @@ -72,6 +76,9 @@ def method_missing(method, *args, &block) | |||
| else | |||
| super | |||
| end | |||
|
|
|||
| rescue JsonApiClient::Errors::ServerError => e | |||
| pretty_error e | |||
There was a problem hiding this comment.
save, update_attributes, and the instance-level method_missing should all catch ServerError and return status codes like find and where do, instead of the exception coming through. Then we can use respondable classes to act on this from metadata instead of catching this exception everywhere in applications.
There was a problem hiding this comment.
do you foresee any other exceptions here we may want to catch?
There was a problem hiding this comment.
json_api_client returns ServerError for every 500 series code from the server, so it should be OK. I guess we really want to catch StandardError here and in querayble, but so far it has not been a problem.
bluetwin
pushed a commit
that referenced
this pull request
Jan 4, 2016
When we try to save/update an object, we should return an error statu…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s code instead of an exception if the server throws