Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert.h is included within the avxsynth namespace in avxplugin.h #99

Closed
ItEndsWithTens opened this issue Jun 15, 2013 · 0 comments
Closed

Comments

@ItEndsWithTens
Copy link

I'm working on some regression tests in C++ for a plugin I'm writing, and have just found my build failing in Linux (though not OS X, for some reason). The error message led me to the discovery that in avxplugin.h, the block of macros including assert.h and crtdbg.h is located within the 'avxsynth' namespace. The unit testing framework I'm using (Catch) also needs assert.h, but it can't find the names it's looking for since the header's already been included under your namespace.

Moving the aforementioned block of macros up out of the namespace fixes the issue for me. I can also work around this by either including catch.hpp before avxplugin.h, or by adding 'using namespace avxsynth' after including your header but before the test framework, but both of those approaches seem fragile to me. Am I right in believing the includes should be pulled out of the namespace, or is your placement of that code by design?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant