Skip to content
This repository has been archived by the owner on Dec 3, 2019. It is now read-only.

Improper validation of max-stale #7

Closed
aw opened this issue Apr 29, 2015 · 0 comments
Closed

Improper validation of max-stale #7

aw opened this issue Apr 29, 2015 · 0 comments
Assignees
@aw
Labels
bug

Comments

@aw
Copy link
Owner

aw commented Apr 29, 2015

Detected this 🐛 in our production setup.

Validation always returns a 504 Gateway Timeout / EXPIRED result when no Cache-Control: max-stale header is provided. This is an error as seen in the RFC:

If no value is assigned to max-stale, then the client is willing to accept a stale response of any age.
@aw aw added the bug label Apr 29, 2015
@aw aw self-assigned this Apr 29, 2015
aw added a commit that referenced this issue Apr 29, 2015
@aw
No max-stale = allow anything. Fixes issue #7
2de99f6
aw added a commit that referenced this issue Apr 29, 2015
@aw
No max-stale = allow anything. Fixes issue #7
ca14542
@aw aw closed this as completed Apr 29, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aw aw

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aw