-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PriceIncreaseStatus in JWSRenewalInfoDecodedPayload should be *int32 #232
Comments
@Daydaylw3 , thank you for your PR. Here is one question, there is NO zero value of |
fair enough! |
And I also found that |
I just added my comment in the PR review. |
Thank you for so quick react and patient :) 👍 |
The
PriceIncreaseStatus
field inJWSRenewalInfoDecodedPayload
should be*int32
would more appropriate, cause base on Apple Doc, it only have 2 possible value(0, 1).But in the old Apple Doc, this field is
string
type. So, when non price_increase happened, this field would be empty.So the same with the new api
But if
PriceIncreaseStatus
isint32
, will be decoded to0
, which indicated thatThat would be odd.
So the same with the
ExpirationIntent
, relative docthe
OfferType
inJWSTransaction
, relative docthe
RevocationReason
inJWSTransaction
, relative docThe text was updated successfully, but these errors were encountered: