Fix Sonar issues

awaescher · Jul 2, 2021 · 59f493a · 59f493a
1 parent c19b053
commit 59f493a
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 12 deletions.
diff --git a/RepoZ.Api.Common/Git/DefaultRepositoryIgnoreStore.cs b/RepoZ.Api.Common/Git/DefaultRepositoryIgnoreStore.cs
@@ -12,7 +12,7 @@ public class DefaultRepositoryIgnoreStore : FileRepositoryStore, IRepositoryIgno
 	{
 		private List<string> _ignores = null;
 		private IEnumerable<IgnoreRule> _rules;
-		private object _lock = new object();
+		private readonly object _lock = new object();
 
 		public DefaultRepositoryIgnoreStore(IErrorHandler errorHandler, IAppDataPathProvider appDataPathProvider)
 			: base(errorHandler)

diff --git a/RepoZ.Api.Common/Git/DefaultRepositoryWriter.cs b/RepoZ.Api.Common/Git/DefaultRepositoryWriter.cs
@@ -21,7 +21,6 @@ public bool Checkout(Api.Git.Repository repository, string branchName)
 		{
             using (var repo = new LibGit2Sharp.Repository(repository.Path))
             {
-                string realBranchName = branchName;
                 Branch branch;
 
                 // Check if local branch exists
@@ -37,7 +36,7 @@ public bool Checkout(Api.Git.Repository repository, string branchName)
                     if (upstreamBranch is null)
                         return false;
 
-                    branch = repo.CreateBranch(branchName, upstreamBranch.Tip);     
+                    _ = repo.CreateBranch(branchName, upstreamBranch.Tip);     
                     this.SetUpstream(repository, branchName, upstreamBranch.FriendlyName);
 
                     branch = Commands.Checkout(repo, branchName);

diff --git a/RepoZ.Api.Common/Git/FileRepositoryStore.cs b/RepoZ.Api.Common/Git/FileRepositoryStore.cs
@@ -13,7 +13,7 @@ public abstract class FileRepositoryStore : IRepositoryStore
 	{
 		private readonly IErrorHandler _errorHandler;
 
-		public FileRepositoryStore(IErrorHandler errorHandler)
+		protected FileRepositoryStore(IErrorHandler errorHandler)
 		{
 			_errorHandler = errorHandler;
 		}

diff --git a/RepoZ.Api.Common/Git/IgnoreRule.cs b/RepoZ.Api.Common/Git/IgnoreRule.cs
@@ -4,7 +4,7 @@ namespace RepoZ.Api.Common.Git
 {
 	public class IgnoreRule
 	{
-		private Func<string, bool> _comparer;
+		private readonly Func<string, bool> _comparer;
 
 		public IgnoreRule(string pattern)
 		{

diff --git a/RepoZ.Api.Common/Git/ProcessExecution/ProcessExecutingGitCommander.cs b/RepoZ.Api.Common/Git/ProcessExecution/ProcessExecutingGitCommander.cs
@@ -103,12 +103,6 @@ private void RedirectStderr(ProcessStartInfo startInfo)
 			startInfo.StandardErrorEncoding = _encoding;
 		}
 
-		private void RedirectStdin(ProcessStartInfo startInfo)
-		{
-			startInfo.RedirectStandardInput = true;
-			// there is no StandardInputEncoding property, use extension method StreamWriter.WithEncoding instead
-		}
-
 		protected virtual string Start(Api.Git.Repository repository, string[] command, Action<ProcessStartInfo> initialize)
 		{
 			var timeout = (int)TimeSpan.FromSeconds(10).TotalMilliseconds;

diff --git a/RepoZ.Api/Git/RepositoryViewExtensions.cs b/RepoZ.Api/Git/RepositoryViewExtensions.cs
@@ -39,7 +39,7 @@ private static bool MatchesFilter(IRepositoryView repositoryView, string filter,
 			if (useRegex)
 				return Regex.IsMatch(filterProperty, filter, RegexOptions.IgnoreCase);
 
-			return filterProperty.IndexOf(filter, StringComparison.OrdinalIgnoreCase) > -1;
+			return filterProperty?.IndexOf(filter, StringComparison.OrdinalIgnoreCase) > -1;
 		}
 	}
 }