Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default values for the with_item values for 13.18. #90

Closed
wants to merge 5 commits into from

Conversation

memelet
Copy link
Contributor

@memelet memelet commented Mar 19, 2016

Add default empty array value for the with_item values for 13.18.
resolves #89

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.336% when pulling 8a7ea90 on systeminsights:wip/issue-89 into 5ee5b8c on awailly:master.

@awailly awailly self-assigned this Mar 19, 2016
@awailly
Copy link
Owner

awailly commented Mar 19, 2016

Waiting for comments in #89 before merging.

@pchaigno
Copy link
Collaborator

We should also add a test for this in .travis.yml.

@awailly
Copy link
Owner

awailly commented Mar 23, 2016

I am not sure on how we can test this. Can you show the high level idea?

@pchaigno
Copy link
Collaborator

In .travis.yml, we currently have 3 tests configured: a syntax check, the main test and an idempotence check. For the main test, we use a pretty simple playbook. We could add a fourth test with a playbook that skips the CIS role as in @memelet's example in #89; something like:

---
- hosts: all
  roles:
    - cis-ubuntu-ansible
  when: False

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.342% when pulling 14c8cc1 on systeminsights:wip/issue-89 into a4fe7ea on awailly:master.

@memelet
Copy link
Contributor Author

memelet commented May 20, 2016

Is there something I need to do that is blocking this merge?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.818% when pulling 5694635 on systeminsights:wip/issue-89 into 5aada5e on awailly:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.818% when pulling cce10f1 on systeminsights:wip/issue-89 into 5aada5e on awailly:master.

@awailly
Copy link
Owner

awailly commented Jul 9, 2016

Should be fixed with #108.

@pchaigno pchaigno closed this Jul 10, 2016
@memelet memelet deleted the wip/issue-89 branch February 28, 2017 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Role fails to run if skipped
4 participants