Fix Docker build #97
Merged
Fix Docker build #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why the change towards 16.04? Our playbook and CIS were specifically aiming 14.04. This is a good time to introduce multiple versions support. So far, there is no benchmark available for the LTS 16.04 on https://benchmarks.cisecurity.org/downloads/browse/index.cfm?category=benchmarks.os.linux.ubuntu. |
The last Ansible version (2.0.2.0-1) requires new dependencies depending on the Linux distribution
Replace Ubuntu 14.10 with Ubuntu 16.04 in Dockerfile
pchaigno
force-pushed
the
fix-dockerfile
branch
from
4d07f54
to
d19edbd
Compare
|
As discussed offline, this keeps 14.04 in the Dockerfile; it just replaces 14.10 with 16.04. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the Dockerfile, which contains tests for several Linux distributions. It also replaces Ubuntu 14.10 by Ubuntu 16.04.
Our Docker build has been failing for some time now. Unfortunately, this build is not very useful (even though it runs limited tests on more Linux distributions than any other CI) since we do not receive automatic notifications when it fails. It may not be too long to build an IRC notification system from the webhook feature they offer...