Remove old Groovy code related to AwaitilityTrait and AwaitilitySupport #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… AwaitilitySupport AwaitilityGroovyBridge needs to be removed because depending on random factors (class loading?) it can overwrite code added by AwaitilityExtensionModule and cause non-bool closures to fail - this is reproduced by tests added in this commit. AwaitilityTrait and AwaitilitySupport can be made empty as AwaitilityExtensionModule does their work now. They are left only to prevent a breaking API change.
pkubowicz
changed the title
pkubowicz
changed the title
|
Thanks again!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AwaitilityGroovyBridge needs to be removed because depending on random factors
(class loading?) it can overwrite code added by AwaitilityExtensionModule and
cause non-bool closures to fail - this is reproduced by tests added in this commit.
AwaitilityTrait and AwaitilitySupport can be made empty as AwaitilityExtensionModule
does their work now. They are left only to prevent a breaking API change.