Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail to compile with proto3-suite >= 0.5.0 #23

Closed
Friede80 opened this issue Jul 8, 2022 · 1 comment
Closed

Tests fail to compile with proto3-suite >= 0.5.0 #23

Friede80 opened this issue Jul 8, 2022 · 1 comment
Assignees

Comments

@Friede80
Copy link
Contributor

Friede80 commented Jul 8, 2022

Brought up in #22

When using proto3-suite >= 0.5.0

Building test suite 'test' for grpc-mqtt-0.1.0.0..
[ 1 of 16] Compiling Proto.Message    ( gen/test/Proto/Message.hs, /home/matt/Code/grpc-mqtt/dist-newstyle/build/x86_64-linux/ghc-8.10.4/grpc-mqtt-0.1.0.0/t/test/build/test/test-tmp/Proto/Message.o, /home/matt/Code/grpc-mqtt/dist-newstyle/build/x86_64-linux/ghc-8.10.4/grpc-mqtt-0.1.0.0/t/test/build/test/test-tmp/Proto/Message.dyn_o ) [Proto3.Suite.Types changed]
[ 2 of 16] Compiling Proto.Service    ( gen/test/Proto/Service.hs, /home/matt/Code/grpc-mqtt/dist-newstyle/build/x86_64-linux/ghc-8.10.4/grpc-mqtt-0.1.0.0/t/test/build/test/test-tmp/Proto/Service.o, /home/matt/Code/grpc-mqtt/dist-newstyle/build/x86_64-linux/ghc-8.10.4/grpc-mqtt-0.1.0.0/t/test/build/test/test-tmp/Proto/Service.dyn_o ) [Network.GRPC.HighLevel.Server.Unregistered changed]

gen/test/Proto/Service.hs:143:30: error:
    Not in scope: ‘optMaxMetadataSize’
    |
143 |                              optMaxMetadataSize = serverMaxMetadataSize})
    |                              ^^^^^^^^^^^^^^^^^^

This looks like its related to this change in grpc-haskell: awakesecurity/gRPC-haskell@1127770

@Friede80
Copy link
Contributor Author

Friede80 commented Jul 8, 2022

Ahh, I think I see what is happening. Our nix overlay pins grpc-haskell built with proto3-suite-0.4.3, so when I fix proto3-suite >= 0.5.0, cabal resolves the dependencies and tries to use grpc-haskell-0.1.0 because that is the latest version on Hackage.

So I think the only real issue here is that we should add the version contraint grpc-haskell >= 0.3.0

@riz0id riz0id self-assigned this Aug 8, 2022
@riz0id riz0id closed this as completed Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants