Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hocker-config and hocker-layer fail the response integrity check #23

Closed
ixmatus opened this issue Dec 1, 2017 · 0 comments · Fixed by #25
Closed

hocker-config and hocker-layer fail the response integrity check #23

ixmatus opened this issue Dec 1, 2017 · 0 comments · Fixed by #25
Assignees
@ixmatus
Labels
bug

Comments

@ixmatus
Copy link
Collaborator

ixmatus commented Dec 1, 2017

hocker-config and hocker-layer both check the Docker-Content-Digest hash to ensure the integrity of the response body. However, because we only accept the image manifest media type this is affected by a regression (#2395) in behavior in which the Docker-Content-Digest header contains a hash value from the image manifest list even when the image manifest is the only media type the client accepts.

For example, hocker-config will fail with this error message:

hocker-config: Response content hash is 8072a54ebb3bc136150e2f2860f00a7bf45f13eeb917cca2430fcd0054c8e51b
and it does not match the addressable content hash
be0cd392e45be79ffeffa6b05338b98ebb16c87b255f48e297ec7f98e123905c
@ixmatus ixmatus added the bug label Dec 1, 2017
@ixmatus ixmatus self-assigned this Dec 1, 2017
@ixmatus ixmatus mentioned this issue Dec 1, 2017
Open
ixmatus added a commit that referenced this issue Dec 1, 2017
@ixmatus
Remove response integrity check of config.json and layer
1ccf34a 
This change is being made because the `Docker-Content-Digest` value
sent back by docker distribution is a hash digest from the image
manifest list when only the image manifest is accepted by the client.

This issue on docker distribution tracks the regression:
distribution/distribution#2395

Fixes #23

Issue #24 tracks reverting this change when the docker distribution
issue is resolved.
@ixmatus ixmatus mentioned this issue Dec 1, 2017
Merged
ixmatus added a commit that referenced this issue Dec 1, 2017
@ixmatus
Fix response integrity check bug (#23) and fix missing tests data (#25)
63129b1 
* Remove response integrity check of config.json and layer

This change is being made because the `Docker-Content-Digest` value
sent back by docker distribution is a hash digest from the image
manifest list when only the image manifest is accepted by the client.

This issue on docker distribution tracks the regression:
distribution/distribution#2395

Fixes #23

Issue #24 tracks reverting this change when the docker distribution
issue is resolved.

* Add the hocker tests data files

This fixes a test failure caused by the tests data dir not being
included in the cabal source distribution.
ixmatus added a commit that referenced this issue Feb 11, 2018
@ixmatus
Remove the response integrity check
be9607e 
In commit 63129b1 I removed the check for the function that fetches
layers but did not remove it for the function that fetches a whole
image.

This change is being made because the `Docker-Content-Digest` value
sent back by docker distribution is a hash digest from the image
manifest list when only the image manifest is accepted by the client.

This issue on docker distribution tracks the regression:
distribution/distribution#2395

Fixes #23

Issue #24 tracks reverting this change when the docker distribution
issue is resolved.

This change also fixes a test failure caused by the tests data dir not
being included in the cabal source distribution.
ixmatus added a commit that referenced this issue Feb 12, 2018
@ixmatus
Fix hocker-image (#34)
19c51d0 
* Remove the response integrity check

In commit 63129b1 I removed the check for the function that fetches
layers but did not remove it for the function that fetches a whole
image.

This change is being made because the `Docker-Content-Digest` value
sent back by docker distribution is a hash digest from the image
manifest list when only the image manifest is accepted by the client.

This issue on docker distribution tracks the regression:
distribution/distribution#2395

Fixes #23

Issue #24 tracks reverting this change when the docker distribution
issue is resolved.

This change also fixes a test failure caused by the tests data dir not
being included in the cabal source distribution.

* Fix the incorrect serialization of the registry URI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ixmatus ixmatus

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix response integrity check bug (#23) and fix missing tests data awakesecurity/hocker
1 participant
@ixmatus