Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile-proto-file does not respect the package directive #153

Open
ProofOfKeags opened this issue May 14, 2021 · 2 comments
Open

compile-proto-file does not respect the package directive #153

ProofOfKeags opened this issue May 14, 2021 · 2 comments

Comments

@ProofOfKeags
Copy link

Trying to compile these protobufs here: https://github.com/lightningnetwork/lnd/blob/master/lnrpc/rpc.proto#L2421

It seems that it does not recognize the package prefix that is defined here: https://github.com/lightningnetwork/lnd/blob/master/lnrpc/rpc.proto#L3

Is this a bug or a limitation of the current implementation?

@ProofOfKeags
Copy link
Author

Here's how it is defined by the protobuf3 spec: https://developers.google.com/protocol-buffers/docs/proto3#packages

I suppose the question is that if I were to submit a patch, what modules would I begin looking in here?

@Gabriella439
Copy link
Contributor

Sorry for the late reply. This is definitely a bug in the current implementation. The main module that you would want to look at is Proto3.Suite.DotProto.Generate:

https://github.com/awakesecurity/proto3-suite/blob/master/src/Proto3/Suite/DotProto/Generate.hs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants