Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

attr: add ImagePos #61

Merged
merged 2 commits into from
Aug 10, 2020
Merged

attr: add ImagePos #61

merged 2 commits into from
Aug 10, 2020

Conversation

tormath1
Copy link
Contributor

@tormath1 tormath1 commented Aug 7, 2020

Hi,

I'd like to merge this attribute ImagePos (https://graphviz.org/doc/info/attrs.html#d:imagepos). Let me know if I need to add tests / other things. 馃槂

This attribute can only support a set of value:

  • tl | Top Left
  • tc | Top Centered
  • tr | Top Right
  • ml | Middle Left
  • mc | Middle Centered (the default)
  • mr | Middle Right
  • bl | Bottom Left
  • bc | Bottom Centered
  • br | Bottom Right

Do we want to add a way to verify the value given by the user for this attribute ?

@awalterschulze
Copy link
Owner

Thank you, in principle this is a great idea.
I don't know how I missed this, good catch :)

I think a good place to start is to add a test, that uses the anal function.
https://github.com/awalterschulze/gographviz/blob/master/analysewrite_test.go#L104

This should reveal if you missed any steps.
If there is any doubt please don't hesitate to ask a question :)

@tormath1
Copy link
Contributor Author

Hi @awalterschulze, it's done for the test. I simply added one test-case for imagepos = tc.

By the meantime, do you think it's possible to add Inframap (https://github.com/cycloidio/inframap) to the README (in the Users section). It's an open-source tool used to generate graph representing cloud infrastructure, we are using gographviz for the dot generation. :)

@awalterschulze awalterschulze merged commit 794ba28 into awalterschulze:master Aug 10, 2020
@awalterschulze
Copy link
Owner

Thank you this looks great :)

@tormath1 yes please create a pull request to add Inframap to the users list in the Readme, that would be amazing :D

@tormath1 tormath1 deleted the mt-add-attr-imagepos branch August 10, 2020 08:31
tormath1 added a commit to cycloidio/inframap that referenced this pull request Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants