Merge pull request #6 from meonkeys/dynamic-nightwatch-config

use dynamic path to selenium server jar

bin/starrynight.js

@@ -57,6 +57,9 @@ var Future = require('fibers/future');
 // so we can get the npm install prefix
 var npm = require('npm');
 
+// for _.extend()ing the process.env object
+var _ = require('underscore');
+
 
 //==================================================================================================
 // FILE LINKING
@@ -543,12 +546,8 @@ function parseRunTestArguments(npmPrefix){
               nightwatchCommand = 'nightwatch';
             }
 
-            //console.log('Config file location: ' + configFileLocation);
-
-            // TODO:  can we specify the server path via the command line, so it doesn't need to be in the json file?
-            // different node versions will break this
-            // alternatively, can we specify node 0.10.38 in particular?
-            var nightwatch = childProcess.spawn(nightwatchCommand, ['-c', configFileLocation], function(error, result){
+            var nightwatchEnv = _.extend(process.env, {npm_config_prefix: npmPrefix});
+            var nightwatch = childProcess.spawn(nightwatchCommand, ['-c', configFileLocation], {env: nightwatchEnv}, function(error, result){
               if(error){
                 console.log("[StarryNight] ERROR spawning nightwatch: ", error);
                 //process.exit(1);

configs/nightwatch/config.json

@@ -11,7 +11,7 @@
 
   "selenium" : {
     "start_process" : true,
-    "server_path" : "/usr/local/lib/node_modules/starrynight/node_modules/selenium-server-standalone-jar/jar/selenium-server-standalone-2.45.0.jar",
+    "server_path" : "${npm_config_prefix}/lib/node_modules/starrynight/node_modules/selenium-server-standalone-jar/jar/selenium-server-standalone-2.45.0.jar",
     "log_path" : "tests/nightwatch/logs",
     "host" : "127.0.0.1",
     "port" : 4444,

package.json

@@ -14,7 +14,8 @@
     "request": "2.54.0",
     "fibers": "^1.0.2",
     "find-files": "^0.0.3",
-    "replace": "0.3.0"
+    "replace": "0.3.0",
+    "underscore": "^1.8.3"
   },
   "engines": {
     "node": ">= 0.4.0"