Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ask npm for install prefix #3

Merged
merged 1 commit into from
Apr 15, 2015

Conversation

meonkeys
Copy link
Contributor

This should fix #1.

Lots of whitespace changed because I indented a long switch block. This diff is short if you ignore whitespace changes.

@meonkeys meonkeys mentioned this pull request Apr 15, 2015
@awatson1978
Copy link
Owner

Ooooo.... This look great. Thanks so much! Have you run through the test script and is everything working? I'm tempted to merge this in, and let it sit for a few days before publishing to npm.

@meonkeys
Copy link
Contributor Author

Cool!

Test script? No, I just ran bin/starrynight.js stand-alone and made sure it could find npm's prefix.

Is there an easy way to test everything?

@awatson1978
Copy link
Owner

:)
That should probably be sufficient.

Right now, the walkthrough in the Examples section on http://starrynight.meteor.com is working as a test script. Need to automate it; but for the time being its better than nothing. Will want to run through that script before publishing to npm.

awatson1978 added a commit that referenced this pull request Apr 15, 2015
@awatson1978 awatson1978 merged commit 4c80109 into awatson1978:master Apr 15, 2015
@meonkeys meonkeys deleted the fix-npm-prefix-dir branch April 15, 2015 16:38
@meonkeys
Copy link
Contributor Author

Ah, gotcha. I used sudo npm link to globally install from my clone's working dir, then I was able to test this version of starrynight.

Already found one issue walking through the script. I'll file it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants