New capability: a minimal nightwatch scaffold. Zero lint errors. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to be committed: new file: scaffolds/sample-tests/nightwatch-minimal/globals.json new file: scaffolds/sample-tests/nightwatch-minimal/logs/selenium-debug.log new file: scaffolds/sample-tests/nightwatch-minimal/walkthroughs/appLayout.js modified: tool/generate-autoconfig.js modified: tool/scaffold.js
| log.info('------------------------------------------'); | ||
| log.info('Removing "custom path" elements .... '); | ||
| delete autoConfigObject.custom_commands_path; | ||
| delete autoConfigObject.custom_assertions_path; |
|
Dude, this is great. |
awatson1978
added a commit
that referenced
this pull request
Jul 29, 2015
New capability: a minimal nightwatch scaffold. Zero lint errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically this is a stripped version of scaffolds/sample-tests/nightwatch.
tool/generate-autoconfig.js has a new function, called from two places, to replace the anonymous file save function, that was only called once.
NOTE : Changes to documentation still to do.
tool/generate-autoconfig.js is now free of lint errors, but has warnings about use of single quotes.
Will fix those when there are no other changes in the file that would be obscured.
Changes committed:
new file: scaffolds/sample-tests/nightwatch-minimal/globals.json
new file: scaffolds/sample-tests/nightwatch-minimal/logs/selenium-debug.log
new file: scaffolds/sample-tests/nightwatch-minimal/walkthroughs/appLayout.js
modified: tool/generate-autoconfig.js
modified: tool/scaffold.js