Added Wizard Support for more Yeelight products, and workaround for music-mode reset by some of them. (Fixes: #748) #750
Conversation
ratawhisk
changed the title
|
Hi If it works, then I could merge both our changes into this PR. Unfortunately, the Yeelight controller probably suffers from other serious problems because it is very similar to the old Philips Hue controller, which took me a lot of time to sort out and take into account various possible scenarios. Without a test kit, I won't even attempt to refactor this driver in a similar way. So let's hope this small fix will be enough at least for this issue. |
|
Hi, I already made a build with my changes, and testet them for about an hour, mostly the music-mode workaround. |
|
Great! Let me know if it works later and merge changes if it is OK. I suspect that the testing time will not be crucial, but rather the turning on and off of the driver , e.g. when the video source has changed. Or physically turning Yeelight lamp off/on to simulate various device state. But I suspect that other things may come out that are not related to this problem, just like in Philips Hue.... Installers: https://github.com/awawa-dev/HyperHDR/actions/runs/7679690184 |
|
Okay, so i tested different States. Switching the video source (grabber to color/effect or back) works without problems Up to now, the only issue I found, is when I powercycle the bulb. 2024-01-28T14:44:06.669Z [LEDDEVICE4_YEELIGHT] Yeelight device 'yeelink-light-colorc_miapABBB' signals error: 'Write Error: Socket is not connected' 2024-01-28T14:44:45.392Z [LEDDEVICE4_YEELIGHT] (LedDevice.cpp:247) Enable the device |
|
Thank you for your tests and feedback. I added an autoresume for Yeelight: can you check it? https://github.com/awawa-dev/HyperHDR/actions/runs/7687019660 |
|
Tested it a few times, and yes, works perfectly! Always at the first Switch on try, the LED gets back in action. 2024-01-28T18:29:23.380Z [LEDDEVICE4_YEELIGHT] Yeelight device 'yeelink-light-colorc_miapABBB' signals error: 'Write Error: Socket is not connected' |
|
Thank you again. I combined our changes in this PR. Check if it's OK and test the latest build. If you don't find any new problems then I will merge your PR within a few days. |
|
Okay, i will do that. |
|
Up to today, everything worked fine. No new problems! |
|
OK, thank you for the feedback. I just merged these changes. |
|
Just to confirm, it's normal to get this " Ignoring Yeelight error when turning off music mode" log in v20.0 right? There's no way to permanently disable the music mode? |
|
You really do not want to disable the music mode which is using UDP even if it is possible (I dont know if it is). For Philips Hue there is a huge difference when similar entertainment mode (UDP) is enabled or not (REST on TCP). But Philips Hue is a different league in terms of API quality. |
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of web configuration, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing setups:
The PR fulfills these requirements:
Fixes: #xxx[,#xxx], where "xxx" is the issue number)To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: