Parameter to allow manual selection of software / auto mode for Stage3D.requestContext

[ricovitch]

#107

I tried to make the minimum modifications needed to allow for manually selecting Software rendering mode, as an optional parameter of View3D constructor.

I need this myself for testing purpose, and to allow to have two context3d in the same application, one with hardware rendering, and one with software rendering, that i use to generate bitmapdata in real time (very slow with hardware rendering)

[richardolsson]

Thanks for your pull request!

Team, I'm fine with this, although I would prefer a boolean flag (e.g. forceSoftware) instead of a string. It's less error-prone, although granted, also less flexible if there are more options added to Stage3D down the line.

[ricovitch]

Thank you Richard. I think you are right, a boolean flag would be better.

[richardolsson]

Please feel free to make the change.

As a tip for the future, try to use more descriptive commit messages, that actually outlines the change that was made (instead of just saying which file was changed.) Actually, the three commits that you've made to this pull request should probably have been a single commit; none of them will actually work on it's own, and they are all related to the same change.

[ricovitch]

You are totally right Richard, maybe this is due to the fact i used integrated editor on github.com instead of commiting all changes from my working copy...
I cancel this pull request and try to make a clean new one.

[ricovitch]

Hi Richard, as discussed, i closed this pull request and made a new one with "forceSoftware" parameter in a single commit :
#251