Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode headers #88

Merged
merged 19 commits into from
Apr 17, 2020
Merged

Unicode headers #88

merged 19 commits into from
Apr 17, 2020

Conversation

awdeorio
Copy link
Owner

@awdeorio awdeorio commented Apr 15, 2020

Test messages with unicode characters in TO, FROM and SUBJECT. This exposed a bunch of bugs that led to fixing #80 as well.

Closes #49, closes #80

This PR contains a work-around for a bug in future.backports.email.base64mime.header_encode that raises an exception when serializing an email message object containing a base64-encoded UTF8 header. PythonCharmers/python-future#555

@codecov-io
Copy link

codecov-io commented Apr 15, 2020

Codecov Report

Merging #88 into develop will decrease coverage by 0.62%.
The diff coverage is 92.85%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #88      +/-   ##
===========================================
- Coverage    99.65%   99.02%   -0.63%     
===========================================
  Files            5        6       +1     
  Lines          287      309      +22     
===========================================
+ Hits           286      306      +20     
- Misses           1        3       +2     
Impacted Files Coverage Δ
mailmerge/template_message.py 100.00% <ø> (ø)
mailmerge/utils.py 90.00% <90.00%> (ø)
mailmerge/__main__.py 99.21% <100.00%> (+<0.01%) ⬆️
mailmerge/sendmail_client.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 388e89b...480b235. Read the comment docs.

@awdeorio awdeorio marked this pull request as ready for review April 16, 2020 23:07
@awdeorio awdeorio changed the title Bugfix/49 unicode headers Unicode headers Apr 17, 2020
@awdeorio awdeorio merged commit f19b085 into develop Apr 17, 2020
@awdeorio awdeorio deleted the bugfix/49-unicode-headers branch April 17, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent conversion to string Unicode support in message header
2 participants