forked from stripe/react-stripe-js
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Disable require-default-props lint rule
The require-default-props lint rule was being overly restrictive for this use case. There is no good reason to include a value in `defaultProps` if it is truly optional, as that just means that React now has to do the work to merge this `undefined` value into props for no reason. I'd argue that you should just avoid `defaultProps` all together and use destructuring with default values, but that's maybe more personal preference.
- Loading branch information
Brandon Dail
committed
Dec 13, 2019
1 parent
6ff4922
commit 247e45e
Showing
3 changed files
with
2 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters