Strip space before processing single key binding #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abitrolly
referenced
this pull request
May 7, 2021
Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
abitrolly
added a commit
to abitrolly/dive
that referenced
this pull request
May 7, 2021
This uses latest `github.com/awesome-gocui/keybinding` It will also be possible to separate quit shortcuts by space when awesome-gocui/keybinding#3 is merged.
abitrolly
added a commit
to abitrolly/dive
that referenced
this pull request
May 7, 2021
This uses latest `github.com/awesome-gocui/keybinding` It will also be possible to separate quit shortcuts by space when awesome-gocui/keybinding#3 is merged.
|
@mjarkk @glvr182 can we merge this? It allows to use shortcut combinations that are separated be spaces, like This could be used here wagoodman/dive#354 |
|
Sure :) |
|
Thanks a lot. :D |
mark2185
pushed a commit
to mark2185/dive
that referenced
this pull request
Apr 29, 2022
This uses latest `github.com/awesome-gocui/keybinding` It will also be possible to separate quit shortcuts by space when awesome-gocui/keybinding#3 is merged.
wagoodman
pushed a commit
to abitrolly/dive
that referenced
this pull request
Jul 6, 2023
This uses latest `github.com/awesome-gocui/keybinding` It will also be possible to separate quit shortcuts by space when awesome-gocui/keybinding#3 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.