Skip to content
This repository has been archived by the owner on Aug 17, 2021. It is now read-only.

Configurable Timeouts #5

Closed
mkoertgen opened this issue Oct 11, 2017 · 5 comments
Closed

Configurable Timeouts #5

mkoertgen opened this issue Oct 11, 2017 · 5 comments
Assignees
@mkoertgen

Comments

@mkoertgen
Copy link
Member

No description provided.

@mkoertgen mkoertgen self-assigned this Oct 11, 2017
@alex-kuck
Copy link

alex-kuck commented Oct 11, 2017 •
edited

In addition to the timeouts provided to mocha via package.json, which target the timeout for single tests, maybe we should also make timeouts for page.waitForNavigation configurable. We could provide a default value of 0, which disables the timeout, e.g.:

page.waitForNavigation({timeout: 0, waitUntil: 'networkidle'})

c.f. Puppeteer Issue #782 and merged PR

@mkoertgen
Copy link
Member Author

For now, i will opt to support mocha.opts from ./test again.

@mkoertgen
Copy link
Member Author

Also support customized ./test/options.js (if any)

mkoertgen added a commit that referenced this issue Oct 11, 2017
@mkoertgen
Support custom options. Fixes #5
ccaddb7
@mkoertgen
Copy link
Member Author

Network timeouts cannot be configured globally. The default idletimeout of 1s should be ok.

@mkoertgen
Copy link
Member Author

Fixed with ccaddb7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mkoertgen mkoertgen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkoertgen @alex-kuck