Allow for optional, non-html output in action_view #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When html: false is explicitly set, that should not be overridden by the ext/action_view, i.e. defaults must not be forced. Usage scenario: Rails+cucumber+byebug+awesome_print. I type in my view (index.slim) "- byebug". Then I run cucumber test. Then the test stops at that byebug line, providing me with a byebug console in that context from terminal. Then I type "ap product" and I get the default behaviour - a lot of html output in console - not needed. Then I type "ap product, html: false" and to my surprise I get the same output. That's because my html: false was overridden by awesome print ext/action_view.
<pre> not needed when html: false is set by the user.
|
I would love to see this merged. Not all ap usage inside a view is to dump to HTML (I have never used that). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When html: false is explicitly set, that should not be overridden by the ext/action_view, i.e. defaults must not be forced.
Usage scenario:
Rails+cucumber+byebug+awesome_print. I type in my view (index.slim) "- byebug". Then I run cucumber test. Then the test stops at that byebug line, providing me with a byebug console in that context from terminal. Then I type "ap product" and I get the default behaviour - a lot of html output in console - not needed. Then I type "ap product, html: false" and to my surprise I get the same output. That's because my html: false was overridden by awesome print ext/action_view.